Skip to content

Fix external redirect trailing #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2024
Merged

Fix external redirect trailing #598

merged 3 commits into from
Oct 30, 2024

Conversation

@conico974
Copy link
Contributor

Fix #591

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: 5747070

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 26, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@598

commit: 414d3d2

khuezy
khuezy approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small comment.

@conico974 conico974 merged commit bfa1a8c into opennextjs:main Oct 30, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Merged
@conico974 conico974 deleted the fix/external-redirect-trailing branch March 14, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khuezy khuezy khuezy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

External redirects issues without trailing slash

2 participants

@conico974 @khuezy